fix redis: check geo reply member is a string before GetString - #1288
Closed
netliomax25-code wants to merge 1 commit into
Closed
fix redis: check geo reply member is a string before GetString#1288netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Member
|
LGTM |
|
Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Jul 29, 2026
ParseReplyDataArray for GeoPoint in redis/src/storages/redis/parse_reply.cpp reads the first element of each per-member sub-array of a GEORADIUS/GEOSEARCH reply with GetString(), but only checks that the sub-array is non-empty rather than that the element is a string. ReplyData::GetString() resolves through std::get_if, which returns nullptr for a non-string element, so a compromised or MITM'd Redis server that returns an integer or nested array there makes the parser dereference that null pointer while move-constructing member (a UASSERT abort under the sanitizer CI, a null-pointer dereference of a std::string in release). I added an IsString check before the read that throws ParseReplyException, matching the type checks the sibling branches already perform, and covered both the rejected and accepted reply shapes with a test. --- Pull Request resolved: #1288 Co-authored-by: antoshkka <antoshkka@userver.tech> Co-authored-by: antoshkka <antoshkka@userver.tech> commit_hash:b85b0638c485003329d835727ec440421d342412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseReplyDataArray for GeoPoint in redis/src/storages/redis/parse_reply.cpp reads the first element of each per-member sub-array of a GEORADIUS/GEOSEARCH reply with GetString(), but only checks that the sub-array is non-empty rather than that the element is a string. ReplyData::GetString() resolves through std::get_if, which returns nullptr for a non-string element, so a compromised or MITM'd Redis server that returns an integer or nested array there makes the parser dereference that null pointer while move-constructing member (a UASSERT abort under the sanitizer CI, a null-pointer dereference of a std::string in release). I added an IsString check before the read that throws ParseReplyException, matching the type checks the sibling branches already perform, and covered both the rejected and accepted reply shapes with a test.